Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly use TNF_ENABLE_XML_CREATION #1751

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Properly use TNF_ENABLE_XML_CREATION #1751

merged 2 commits into from
Dec 19, 2023

Conversation

ramperher
Copy link
Collaborator

@ramperher ramperher commented Dec 19, 2023 •
edited
Loading

build-depends: redhatci/ansible-collection-redhatci-ocp#100

In run-container.sh, it's used TNF_ENABLE_XML_CREATION instead of ENABLE_XML_CREATION var. Fixing that

greyerof
greyerof approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@greyerof greyerof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both versions work, but I also prefer the "TNF_"-prefixed one.

@ramperher ramperher changed the title Properly use ENABLE_XML_CREATION Properly use TNF_ENABLE_XML_CREATION Dec 19, 2023
@ramperher
Copy link
Collaborator Author

Both versions work, but I also prefer the "TNF_"-prefixed one.

I agree, I've included TNF_ prefix

@sebrandon1 sebrandon1 merged commit 664dbe6 into redhat-best-practices-for-k8s:ginkgo_removal Dec 19, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyerof greyerof greyerof approved these changes

@edcdavid edcdavid edcdavid approved these changes

@sebrandon1 sebrandon1 sebrandon1 approved these changes

Assignees
No one assigned
Labels
ginkgoless
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramperher @sebrandon1 @edcdavid @greyerof